This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Normalize the sortableTable on about:preferences #10789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luixxiul
added
feature/about-pages
polish
NejcZdovc
reviewed
Sep 11, 2017
| css(styles.alignRight), // sites | ||
| css(styles.alignLeft), // include | ||
| css(styles.alignRight, styles.column_sites), // sites | ||
| css(styles.alignCenter), // include |
There was a problem hiding this comment.
was this done intentionally? we are not using align center anywhere else
There was a problem hiding this comment.
It is intentional (in terms of l10n). I'm taking a screenshot.
There was a problem hiding this comment.
Check the case like this:
Before:
After:
luixxiul
added
priority/P4
| @@ -3,7 +3,7 @@ | |||
| * You can obtain one at http://mozilla.org/MPL/2.0/. */ | |||
|
|
|||
| const React = require('react') | |||
| const {StyleSheet, css} = require('aphrodite') | |||
| const {StyleSheet, css} = require('aphrodite/no-important') | |||
| <span className={css( | ||
| styles.actionIcons__icon, | ||
| styles.actionIcons__icon_pin, | ||
| pinned && styles.actionIcons__icon_pin_pinned |
There was a problem hiding this comment.
nit: this could be styles.actionIcons__icon_pin_isPinned
| @@ -350,11 +357,18 @@ const styles = StyleSheet.create({ | |||
| }, | |||
|
|
|||
| verifiedTd: { | |||
| padding: '0 0 0 15px' | |||
| // Set the same padding with the padding-top and padding-bottom | |||
| paddingRight: '.3ch !important', | |||
There was a problem hiding this comment.
I like using ch units for width/height but for padding seems obscure. Let me know your thoughts on why this
There was a problem hiding this comment.
it sounds fair. I will revisit the padding values of sortable table to see which one works most properly.
cezaraugusto
previously approved these changes
Sep 15, 2017
There was a problem hiding this comment.
left a comment in https://github.com/brave/browser-laptop/pull/10789/files#r139240607. lmk your thoughts but otherwise this lgtm
|
@cezaraugusto I've reset the padding with consts: |
|
blocking now until 0.19.x |
8 tasks
|
This blocks #10951 |
ghost
removed
the
priority/P5
luixxiul
dismissed
cezaraugusto’s stale review
Additional commits have been added.
Codecov Report
@@ Coverage Diff @@
## master #10789 +/- ##
==========================================
- Coverage 53.38% 53.36% -0.03%
==========================================
Files 274 274
Lines 26020 26019 -1
Branches 4170 4169 -1
==========================================
- Hits 13891 13884 -7
- Misses 12129 12135 +6
|
bbondy
modified the milestones:
0.21.x (Developer Channel),
0.20.x (Beta Channel),
Backlog
luixxiul
added
PR/pending-review
QA/test-plan-specified
and removed
priority/P3
luixxiul
changed the title
luixxiul
removed
the
polish
added 3 commits
November 19, 2017 17:56
Addresses #10263 Addresses #10788 Closes #10356 - Polish action icons - Polish verified icon placement - Remove alignRight from the sites column (it should be aligned to the left as default) - Align the include switches to the center - Align the action buttons to the center Test Plan: 1. Visit https://www.youtube.com/user/latenight 2. Open about:preferences#payments 3. Make sure the channel title is aligned to the left
- Replace headerClassNames with headerStyles - Replace columnClassNames with columnStyles on ledgerTable - Replace bodyClassNames with bodyStyles - Remove customCellClassesStr - Remove .th-inner - Set white-space: nowrap to ledgerTable.js Auditors: Test Plan: 1. Run `npm run add-simulated-synopsis-visits 100` 2. Open about:preferences#payments 3. Pin some entries 4. Make sure the table is properly displayed
cezaraugusto
approved these changes
Nov 21, 2017
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This blocks #10951
Addresses #10263
Addresses #10788
Closes #10356
Regression Test:
Test Plan:
Test Plan 2:
npm run add-simulated-synopsis-visits 100Submitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
Tests